Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filter out roles not defined by OSP #1114

Conversation

JordanGerada3
Copy link
Contributor

Description

  • Added filter function to only show pre-selected roles from OSP

Why

User should not be able to select roles that were not pre-selected by the OSP

Issue

#1109

Checklist

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally

Copy link
Contributor

@typecastcloud typecastcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well for me. Thanks!

@JordanGerada3 JordanGerada3 marked this pull request as ready for review September 16, 2024 09:05
Copy link
Contributor

@ss-nikunj ss-nikunj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

sonarcloud bot commented Sep 17, 2024

@oyo oyo merged commit 08ae7a5 into eclipse-tractusx:main Sep 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: USER READY
Development

Successfully merging this pull request may close these issues.

5 participants